update service worker and dependencies #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Type: Bug Fix
juans-chainsafe
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
Test "can view folder content from search result" was skipped due to random issues when is running on the pipeline CC @asnaith
PR looks good !
Ah yes! If it's not reliable and causing too much noise then it's a good call to take it out of the regular execution 👍. Thanks @juans-chainsafe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where users were unable to log in to Files using OAuth (In Brave, FF and Safari).
Updated service worker and redirect.html to latest version resolved the issue. Additionally a temporary workaround that we had been using for staging (using a quiknode ropsten node) is no longer necessary as the team have migrated all required infra to goerli.